Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor controller unit test with proper mock #268

Closed
wants to merge 325 commits into from
Closed

Refactor controller unit test with proper mock #268

wants to merge 325 commits into from

Conversation

zacharya
Copy link
Contributor

@zacharya zacharya commented Apr 5, 2019

Is this a bug fix or adding new feature?
Refactor Cloud interface unit tests to use GoMock

What is this PR about? / Why do we need it?

  • Addresses Refactor controller unit test with proper mock #220 .
  • One thing to discuss - moving cloud.FakeCloudProvider to sanity.fakeCloudProvider required exporting cloud.metadata due to the dependency. I don't see any issues with this, but I figured I'd bring it up in case some of the maintainers see problems.

What testing is done?
Both make test and make test-sanity are running fine.

k8s-ci-robot and others added 30 commits October 22, 2018 14:57
@k8s-ci-robot
Merge pull request #69 from bertinatto/switch_alpine
1c52331 
Switch to Alpine 3.8 as base image
@k8s-ci-robot
Merge pull request #76 from leakingtapan/zone-doc
ea952cb 
Update README for driver features
Rename e2e test to be integ test
4e86052 
m
Fix gofmt
4a26ffd
Rename verify-all to verify-all.sh
93bf949
@k8s-ci-robot
Merge pull request #78 from leakingtapan/rename
28a33b0 
Rename e2e test to be integ test
Add support for creating encrypted volume and unit test
fdf872b 
Fixes: #16
@k8s-ci-robot
Merge pull request #80 from leakingtapan/kms
b563f34 
Add support for creating encrypted volume
Remove unit test and sanity test in favor of prow job
2f8600c
Merge pull request #81 from leakingtapan/udpate-travis
eaab0f0 
Remove unit test and sanity test in favor of prow job
Update copyright years
a421b86
Merge pull request #84 from leakingtapan/copyright
3637146 
Update copyright years
Refactor GetDevice method.
b2d9eab 
Remove setting `releaseFunc` when device is already assigned since the
same func is set in`newBlockDevice`
Remove unnecessary error condition in getDevicenamesInUse
797529b
Switch to use docker hub repo amazon/aws-ebs-csi-driver
43eb05b
@k8s-ci-robot
Merge pull request #88 from leakingtapan/dockerhub
ea90fd2 
Switch to use dockerhub repo amazon/aws-ebs-csi-driver
@k8s-ci-robot
Merge pull request #85 from leakingtapan/refactor-devmgr
b1335a9 
Refactor `GetDevice` method.
Swtich to use amazon linux 2 as base image
99128f5
@k8s-ci-robot
Merge pull request #91 from leakingtapan/alinux
fe3427d 
Swtich to use amazon linux 2 as base image
Update driver version to 0.1.0-alpha
0343448 
Switch to use golang1.11.1-stretch as build image so that we can
delegate to make file for binary compilation without duplicating the
logic in both makefile and dockerfile.
Switch to use go 1.11.1 for travis
f1d58c9
Merge pull request #93 from leakingtapan/travis
bfdbb68 
Switch to use go 1.11.1 for travis
Use session.Must to enforce a valid session is created
d0d7869
@k8s-ci-robot
Merge pull request #90 from leakingtapan/version
b515eac 
Update driver version to 0.1.0-alpha
Merge pull request #92 from leakingtapan/session
6286f5e 
Use session.Must to enforce a valid session is created
Fix misspelling
f94f56f
@k8s-ci-robot
Merge pull request #96 from leakingtapan/misspell
43552fe 
Fix misspelling
Add golint verification
97c944f 
Fixes: #83
Fix errors reported by golangci-lint
e8ca56d
@k8s-ci-robot
Merge pull request #95 from leakingtapan/golint
0d3f11e 
Add golint verification
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zacharya
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ddebroy

If they are not already assigned, you can assign the PR to them by writing /assign @ddebroy in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @zacharya. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 5, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 577

  • 22 of 26 (84.62%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+4.9%) to 70.042%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/fakes.go 0 1 0.0%
pkg/driver/controller.go 12 15 80.0%
Files with Coverage Reduction New Missed Lines %
pkg/driver/controller.go 1 66.77%
Totals Coverage Status
Change from base Build 575: 4.9%
Covered Lines: 996
Relevant Lines: 1422
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 5, 2019
@zacharya zacharya closed this Apr 5, 2019
jsafrane pushed a commit to jsafrane/aws-ebs-csi-driver that referenced this pull request Jun 11, 2024
@openshift-merge-bot
Merge pull request kubernetes-sigs#268 from openshift-bot/art-consist…
3260bf2 
…ency-openshift-4.17-ose-aws-ebs-csi-driver

OCPBUGS-34232: Updating ose-aws-ebs-csi-driver-container image to be consistent with ART for 4.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@zacharya @k8s-ci-robot @coveralls @bertinatto @callahanca @dkoshkin @d-nishi @gyuho @frittentheke @tsmetana